linux-kernel - Re: [PATCH v2] staging: esp8089: add new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160821150944.GA30371@kroah.com>
Date:   Sun, 21 Aug 2016 17:09:44 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Icenowy Zheng <icenowy@...c.xyz>
Cc:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] staging: esp8089: add new driver

On Tue, Jun 21, 2016 at 08:17:14AM -0700, Greg KH wrote:
> On Tue, Jun 21, 2016 at 07:35:24AM +0800, Icenowy Zheng wrote:
> > The driver is only a working port of a badly written driver extracted from an old and vendor-specified kernel source.
> > I cannot promise the code style (although I did indent -kr -i8).
> > I cannot also promise the effect.
> 
> I don't understand this at all, sorry.
> 
> Why should we accept this driver?  Who is going to maintain it?  What
> needs to be done to it?
> 
> And why are you top-posting?  :)

Dropping from my queue due to lack of a response.

If you fix it up, please resend it, but we need the answers to the above
questions if you do so.

thanks,

greg k-h