linux-kernel - Re: [PATCH 6/7] random: make /dev/urandom scalable for silly userspace programs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160821113652.y7r3uhdxymcon2zx@thunk.org>
Date:   Sun, 21 Aug 2016 07:36:52 -0400
From:   Theodore Ts'o <tytso@....edu>
To:     Jan Varho <jan.varho@...il.com>
Cc:     Linux Kernel Developers List <linux-kernel@...r.kernel.org>,
        linux-crypto@...r.kernel.org, smueller@...onox.de,
        herbert@...dor.apana.org.au, andi@...stfloor.org,
        sandyinchina@...il.com, jsd@...n.com, hpa@...or.com
Subject: Re: [PATCH 6/7] random: make /dev/urandom scalable for silly
 userspace programs

On Sun, Aug 21, 2016 at 12:53:15PM +0300, Jan Varho wrote:
> On Mon, Jun 13, 2016 at 6:48 PM, Theodore Ts'o <tytso@....edu> wrote:
> > +static inline void maybe_reseed_primary_crng(void)
> > +{
> > +       if (crng_init > 2 &&
> > +           time_after(jiffies, primary_crng.init_time + CRNG_RESEED_INTERVAL))
> > +               crng_reseed(&primary_crng, &input_pool);
> > +}
> 
> Is the above function (which is now in 4.8-rc2) supposed to do
> something? It seems to have no callers and the maximum value of
> crng_init is 2.

It's dead code.  Its function got moved into _extra_crng(), and you're
right, these days crng_init never gets above 2.  Thanks for pointing
that out.  I'll take it out as a cleanup patch.

     	   	     	       	 	 - Ted