linux-kernel - Re: [PATCH 2/3] tracing: Add trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 22 Aug 2016 14:00:54 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Binoy Jayan <binoy.jayan@...aro.org>
Cc:     kbuild-all@...org, Arnd Bergmann <arnd@...db.de>,
        linaro-kernel@...ts.linaro.org,
        Daniel Wagner <daniel.wagner@...-carit.de>,
        Carsten Emde <C.Emde@...dl.org>, linux-kernel@...r.kernel.org,
        "Steven Rostedt (Red Hat)" <rostedt@...dmis.org>,
        Binoy Jayan <binoy.jayan@...aro.org>
Subject: Re: [PATCH 2/3] tracing: Add trace_irqsoff tracepoints

Hi Binoy,

[auto build test WARNING on tip/perf/core]
[also build test WARNING on v4.8-rc3 next-20160819]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Binoy-Jayan/tracing-Deference-pointers-without-RCU-checks/20160818-151235
config: x86_64-randconfig-s3-08181449 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:95:0,
                    from include/trace/events/latency.h:42,
                    from kernel/trace/trace_irqsoff.c:22:
   include/trace/events/latency.h: In function 'trace_raw_output_latency_template':
   include/trace/events/latency.h:24:12: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'cycles_t {aka long long unsigned int}' [-Wformat=]
     TP_printk("cpu=%d, latency=%lu", __entry->cpu, __entry->latency)
               ^
   include/trace/trace_events.h:327:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
     trace_seq_printf(s, print);     \
                         ^~~~~
   include/trace/events/latency.h:24:2: note: in expansion of macro 'TP_printk'
     TP_printk("cpu=%d, latency=%lu", __entry->cpu, __entry->latency)
     ^~~~~~~~~
   In file included from include/asm-generic/percpu.h:6:0,
                    from arch/x86/include/asm/percpu.h:552,
                    from arch/x86/include/asm/preempt.h:5,
                    from include/linux/preempt.h:59,
                    from include/linux/spinlock.h:50,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/uapi/linux/timex.h:56,
                    from include/linux/timex.h:56,
                    from include/linux/sched.h:19,
                    from include/linux/uaccess.h:4,
                    from kernel/trace/trace_irqsoff.c:13:
   At top level:
>> kernel/trace/trace_irqsoff.c:29:32: warning: 'ts_preempt' defined but not used [-Wunused-variable]
    static DEFINE_PER_CPU(cycle_t, ts_preempt);
                                   ^
   include/linux/percpu-defs.h:105:19: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
     __typeof__(type) name
                      ^~~~
>> kernel/trace/trace_irqsoff.c:29:8: note: in expansion of macro 'DEFINE_PER_CPU'
    static DEFINE_PER_CPU(cycle_t, ts_preempt);
           ^~~~~~~~~~~~~~
>> kernel/trace/trace_irqsoff.c:28:32: warning: 'ts_irqs' defined but not used [-Wunused-variable]
    static DEFINE_PER_CPU(cycle_t, ts_irqs);
                                   ^
   include/linux/percpu-defs.h:105:19: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
     __typeof__(type) name
                      ^~~~
   kernel/trace/trace_irqsoff.c:28:8: note: in expansion of macro 'DEFINE_PER_CPU'
    static DEFINE_PER_CPU(cycle_t, ts_irqs);
           ^~~~~~~~~~~~~~

vim +/ts_preempt +29 kernel/trace/trace_irqsoff.c

     7	 * From code in the latency_tracer, that is:
     8	 *
     9	 *  Copyright (C) 2004-2006 Ingo Molnar
    10	 *  Copyright (C) 2004 Nadia Yvette Chambers
    11	 */
    12	#include <linux/kallsyms.h>
  > 13	#include <linux/uaccess.h>
    14	#include <linux/module.h>
    15	#include <linux/ftrace.h>
    16	
    17	#include <trace/events/sched.h>
    18	
    19	#include "trace.h"
    20	
    21	#define CREATE_TRACE_POINTS
    22	#include <trace/events/latency.h>
    23	
    24	static struct trace_array		*irqsoff_trace __read_mostly;
    25	static int				tracer_enabled __read_mostly;
    26	
    27	static DEFINE_PER_CPU(int, tracing_cpu);
  > 28	static DEFINE_PER_CPU(cycle_t, ts_irqs);
  > 29	static DEFINE_PER_CPU(cycle_t, ts_preempt);
    30	static DEFINE_PER_CPU(cycle_t, ts_critical_timings);
    31	static DEFINE_RAW_SPINLOCK(max_trace_lock);
    32	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (27602 bytes)