| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 22 Aug 2016 09:27:18 +0200
From: Daniel Vetter <daniel@...ll.ch>
To: Heinrich Schuchardt <xypron.glpk@....de>
Cc: David Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 1/1] drm: avoid exposing kernel stack in
compat_drm_getstats
On Sun, Aug 21, 2016 at 07:56:19PM +0200, Heinrich Schuchardt wrote:
> The C standard does not specify the size of the integer used
> to store an enum. Hence in structure drm_stats32_t alignment
> bytes may exist.
>
> To avoid exposing bytes from the kernel stack it is
> necessary to initialize variable s32 completely.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
Applied to drm-misc, thanks.
-Daniel
> ---
> drivers/gpu/drm/drm_ioc32.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c
> index 57676f8..32a489b 100644
> --- a/drivers/gpu/drm/drm_ioc32.c
> +++ b/drivers/gpu/drm/drm_ioc32.c
> @@ -346,6 +346,7 @@ static int compat_drm_getstats(struct file *file, unsigned int cmd,
> struct drm_stats __user *stats;
> int i, err;
>
> + memset(&s32, 0, sizeof(drm_stats32_t));
> stats = compat_alloc_user_space(sizeof(*stats));
> if (!stats)
> return -EFAULT;
> --
> 2.1.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Powered by blists - more mailing lists