linux-kernel - Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a8g5urhn.fsf@intel.com>
Date:   Mon, 22 Aug 2016 11:39:48 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Heinrich Schuchardt <xypron.glpk@....de>,
        Patrik Jakobsson <patrik.r.jakobsson@...il.com>
Cc:     Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Heinrich Schuchardt <xypron.glpk@....de>
Subject: Re: [PATCH 1/1] drm/gma500: dont expose stack, mrst_lvds_find_best_pll

On Sun, 21 Aug 2016, Heinrich Schuchardt <xypron.glpk@....de> wrote:
> All components of variable clock should be initialized
> to avoid bytes from the kernel stack to be exposed.
>
> Reported-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
> ---
>  drivers/gpu/drm/gma500/oaktrail_crtc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> index 28bd8f3..0277d85 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> @@ -195,6 +195,7 @@ static bool mrst_lvds_find_best_pll(const struct gma_limit_t *limit,
>  	struct gma_clock_t clock;
>  	int err = target;
>  
> +	memset(clock, 0, sizeof(struct gma_clock_t));

Again, did you actually build this? This is hurting not helping us. It
makes me think you didn't try your other patches either.

BR,
Jani.


>  	memset(best_clock, 0, sizeof(*best_clock));
>  
>  	for (clock.m = limit->m.min; clock.m <= limit->m.max; clock.m++) {

-- 
Jani Nikula, Intel Open Source Technology Center