linux-kernel - Re: [PATCH 1/2] drivercore: Add helper macro for misc device boilerplate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201608221650.jQUCcOWC%fengguang.wu@intel.com>
Date:   Mon, 22 Aug 2016 16:50:06 +0800
From:   kbuild test robot <lkp@...el.com>
To:     PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
Cc:     kbuild-all@...org, linux@...linux.org.uk, realmz6@...il.com,
        jdike@...toit.com, richard@....at, marcel@...tmann.org,
        gustavo@...ovan.org, johan.hedberg@...il.com, arnd@...db.de,
        gregkh@...uxfoundation.org, dh.herrmann@...glemail.com,
        jikos@...nel.org, benjamin.tissoires@...hat.com,
        dmitry.torokhov@...il.com, mb@...htnvm.io, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, mst@...hat.com, elias.vds@...il.com,
        akpm@...ux-foundation.org, jcliang@...omium.org,
        holzheu@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org,
        PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>
Subject: Re: [PATCH 1/2] drivercore: Add helper macro for misc device
 boilerplate

Hi PrasannaKumar,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.8-rc3 next-20160822]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/PrasannaKumar-Muralidharan/drivercore-Add-helper-macro-for-misc-device-boilerplate/20160821-151236
config: s390-allyesconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All error/warnings (new ones prefixed by >>):

   In file included from drivers/s390/char/sclp_ctl.c:11:0:
>> include/linux/miscdevice.h:78:2: warning: data definition has no type or storage class
     module_driver(__misc_device, misc_register, misc_deregister)
     ^
>> drivers/s390/char/sclp_ctl.c:129:1: note: in expansion of macro 'module_misc_device'
    module_misc_device(sclp_ctl_device);
    ^
>> include/linux/miscdevice.h:78:2: error: type defaults to 'int' in declaration of 'module_driver' [-Werror=implicit-int]
     module_driver(__misc_device, misc_register, misc_deregister)
     ^
>> drivers/s390/char/sclp_ctl.c:129:1: note: in expansion of macro 'module_misc_device'
    module_misc_device(sclp_ctl_device);
    ^
>> drivers/s390/char/sclp_ctl.c:129:1: warning: parameter names (without types) in function declaration
>> drivers/s390/char/sclp_ctl.c:124:26: warning: 'sclp_ctl_device' defined but not used [-Wunused-variable]
    static struct miscdevice sclp_ctl_device = {
                             ^
   cc1: some warnings being treated as errors

vim +78 include/linux/miscdevice.h

    72	
    73	/*
    74	 * Helper macro for drivers that don't do anything special in module init / exit
    75	 * call. This helps in eleminating of boilerplate code.
    76	 */
    77	#define module_misc_device(__misc_device) \
  > 78		module_driver(__misc_device, misc_register, misc_deregister)
    79	
    80	#define MODULE_ALIAS_MISCDEV(minor)				\
    81		MODULE_ALIAS("char-major-" __stringify(MISC_MAJOR)	\

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (42397 bytes)