linux-kernel - Re: [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160822100045.GA26494@e104818-lin.cambridge.arm.com>
Date:   Mon, 22 Aug 2016 11:00:45 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     Xie Yisheng <xieyisheng1@...wei.com>, mark.rutland@....com,
        linux-mm@...ck.org, sudeep.holla@....com, will.deacon@....com,
        linux-kernel@...r.kernel.org, dave.hansen@...el.com,
        robh+dt@...nel.org, guohanjun@...wei.com,
        akpm@...ux-foundation.org, n-horiguchi@...jp.nec.com,
        linux-arm-kernel@...ts.infradead.org, mike.kravetz@...cle.com
Subject: Re: [RFC PATCH v2 2/2] arm64 Kconfig: Select gigantic page

On Mon, Aug 22, 2016 at 10:03:58AM +0200, Michal Hocko wrote:
> On Mon 22-08-16 10:56:43, Xie Yisheng wrote:
> > Arm64 supports gigantic page after
> > commit 084bd29810a5 ("ARM64: mm: HugeTLB support.")
> > however, it got broken by 
> > commit 944d9fec8d7a ("hugetlb: add support for gigantic page
> > allocation at runtime")
> > 
> > This patch selects ARCH_HAS_GIGANTIC_PAGE to make this
> > function can be used again.
> 
> I haven't double checked that the above commit really broke it but if
> that is the case then
>  
> Fixes: 944d9fec8d7a ("hugetlb: add support for gigantic page allocation at runtime")
> 
> would be nice as well I guess. I do not think that marking it for stable
> is really necessary considering how long it's been broken and nobody has
> noticed...

I'm not sure that commit broke it. The gigantic functionality introduced
by the above commit was under an #ifdef CONFIG_X86_64. Prior
to that we had a VM_BUG_ON(hstate_is_gigantic(h)).

-- 
Catalin