linux-kernel - Re: [PATCH 1/1 linux-next] iommu/amd: remove AMD_IOMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2016 12:50:32 +0200
From:   Joerg Roedel <jroedel@...e.de>
To:     Fabian Frederick <fabf@...net.be>
Cc:     Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1 linux-next] iommu/amd: remove AMD_IOMMU_STATS

On Fri, Aug 12, 2016 at 11:54:47PM +0200, Fabian Frederick wrote:
> Commit e85e8f69cedb
> ("iommu/amd: Remove statistics code")
> removed that config.
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  arch/x86/configs/x86_64_defconfig | 1 -
>  drivers/iommu/amd_iommu_proto.h   | 4 ----
>  2 files changed, 5 deletions(-)
> 
> diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig
> index d28bdab..7ef4a09 100644
> --- a/arch/x86/configs/x86_64_defconfig
> +++ b/arch/x86/configs/x86_64_defconfig
> @@ -255,7 +255,6 @@ CONFIG_RTC_CLASS=y
>  CONFIG_DMADEVICES=y
>  CONFIG_EEEPC_LAPTOP=y
>  CONFIG_AMD_IOMMU=y
> -CONFIG_AMD_IOMMU_STATS=y
>  CONFIG_INTEL_IOMMU=y
>  # CONFIG_INTEL_IOMMU_DEFAULT_ON is not set
>  CONFIG_EFI_VARS=y
> diff --git a/drivers/iommu/amd_iommu_proto.h b/drivers/iommu/amd_iommu_proto.h
> index 0bd9eb3..697bccc 100644
> --- a/drivers/iommu/amd_iommu_proto.h
> +++ b/drivers/iommu/amd_iommu_proto.h
> @@ -78,12 +78,8 @@ static inline int amd_iommu_create_irq_domain(struct amd_iommu *iommu)
>  extern int amd_iommu_complete_ppr(struct pci_dev *pdev, int pasid,
>  				  int status, int tag);
>  
> -#ifndef CONFIG_AMD_IOMMU_STATS
> -
>  static inline void amd_iommu_stats_init(void) { }

That function can be removed too, while you are at it. Thanks for
cleaning that up.


	Joerg