linux-kernel - Re: [PATCH] pinctrl: palmas: fix a possible NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb=MsDM_4eQkjyJCfcFyCs=+RDpLemApAj8YaD9kzyYUg@mail.gmail.com>
Date:   Mon, 22 Aug 2016 14:11:24 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     LABBE Corentin <clabbe.montjoie@...il.com>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: palmas: fix a possible NULL dereference

On Tue, Aug 16, 2016 at 10:36 AM, LABBE Corentin
<clabbe.montjoie@...il.com> wrote:

> of_match_device could return NULL, and so cause a NULL pointer
> dereference later at line 1009:
> pinctrl_data = match->data;
>
> For fixing this problem, we use of_device_get_match_data(), this will
> simplify the code a little by using a standard function for
> getting the match data.
>
> Reported-by: coverity (CID 1324136)
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>

Patch applied.

Yours,
Linus Walleij