linux-kernel - Re: [PATCH -next] drm/i915: Fix non static symbol warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2016 16:03:07 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Wei Yongjun <weiyj.lk@...il.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        David Airlie <airlied@...ux.ie>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/i915: Fix non static symbol warning

On Sun, 21 Aug 2016, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/i915/intel_hotplug.c:480:6: warning:
>  symbol 'i915_hpd_poll_init_work' was not declared. Should it be static?
>
> Also move the '{' to new line.

Thanks for the patch, but we've already fixed this in

commit 24808e96792a860f3e83e2eb69c5190261716924
Author: Chris Wilson <chris@...is-wilson.co.uk>
Date:   Wed Aug 17 12:09:06 2016 +0100

    drm/i915: Mark i915_hpd_poll_init_work as static

BR,
Jani.

>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/gpu/drm/i915/intel_hotplug.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c
> index 5dc2c20..334d47b 100644
> --- a/drivers/gpu/drm/i915/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/intel_hotplug.c
> @@ -477,7 +477,8 @@ void intel_hpd_init(struct drm_i915_private *dev_priv)
>  	spin_unlock_irq(&dev_priv->irq_lock);
>  }
>  
> -void i915_hpd_poll_init_work(struct work_struct *work) {
> +static void i915_hpd_poll_init_work(struct work_struct *work)
> +{
>  	struct drm_i915_private *dev_priv =
>  		container_of(work, struct drm_i915_private,
>  			     hotplug.poll_init_work);
>

-- 
Jani Nikula, Intel Open Source Technology Center