linux-kernel - Re: ath9k: Fix beacon configuration assertion failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r39h3p0f.fsf@purkki.adurom.net>
Date:   Mon, 22 Aug 2016 16:35:28 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Benjamin Berg <benjamin.berg@...n-mesh.com>
Cc:     Adi Ratiu <adi@...rat.com>, linux-wireless@...r.kernel.org,
        ath9k-devel@....qualcomm.com, ath9k-devel@...ts.ath9k.org,
        linux-kernel@...r.kernel.org, Felix Fietkau <nbd@....name>
Subject: Re: ath9k: Fix beacon configuration assertion failure

Benjamin Berg <benjamin.berg@...n-mesh.com> writes:

> On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote:
>> Actually, I see two patches which might be related but not identical:
>> 
>> ath9k: fix client mode beacon configuration
>> https://patchwork.kernel.org/patch/9247699/
>> 
>> ath9k: Fix beacon configuration assertion failure
>> https://patchwork.kernel.org/patch/9281191/
>> 
>> Felix (CCed) & Benjamin: please take a look and advice which one I
>> should take.
>
> Yes, both patches are designed to fix the same issue in my patch.
>
> Felix solution looks entirely correct to me, the second solution seems
> slightly wrong because it prevents the call to ath9k_beacon_config from
> happening instead of ensuring the correct parameter value.
> ath9k_beacon_config needs to be called even if iter_data.beacons is
> false as it disables the interrupts.

Ok, I'll the patch from Felix then. Thanks.

-- 
Kalle Valo