linux-kernel - Re: [PATCH v2 8/8] gpio: Add Aspeed driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYv1+DmipZthL3FyOdwsmWNygOW6=quuS6zstjtFMxv1A@mail.gmail.com>
Date:   Mon, 22 Aug 2016 15:48:35 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Andrew Jeffery <andrew@...id.au>
Cc:     Joel Stanley <joel@....id.au>,
        Alexandre Courbot <gnurou@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Jeremy Kerr <jk@...abs.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Alistair Popple <alistair@...ple.id.au>
Subject: Re: [PATCH v2 8/8] gpio: Add Aspeed driver

On Fri, Aug 19, 2016 at 2:44 PM, Andrew Jeffery <andrew@...id.au> wrote:

> From: Joel Stanley <joel@....id.au>
>
> The Aspeed SoCs contain GPIOs banked by letter, where each bank contains
> 8 pins. The GPIO banks are then grouped in sets of four in the register
> layout.
>
> The implementation exposes multiple banks through the one driver and
> requests and releases pins via the pinctrl subsystem. The hardware
> supports generation of interrupts from all GPIO-capable pins.
>
> A number of hardware features are not yet supported: Configuration of
> interrupt direction (ARM or LPC), debouncing, and WDT reset tolerance
> for output ports.
>
> Signed-off-by: Joel Stanley <joel@....id.au>
> Signed-off-by: Alistair Popple <alistair@...ple.id.au>
> Signed-off-by: Jeremy Kerr <jk@...abs.org>
> Signed-off-by: Andrew Jeffery <andrew@...id.au>

This driver looks good now.

I guess I will have to wait for the rest to be fixed up
before applying.

Yours,
Linus Walleij