linux-kernel - Re: linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160822143020.GA7695@kroah.com>
Date:   Mon, 22 Aug 2016 10:30:20 -0400
From:   Greg KH <gregkh@...uxfoundation.org>
To:     David Binderman <linuxdev.baldrick@...il.com>
Cc:     Larry.Finger@...inger.net, Jes.Sorensen@...hat.com,
        linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        dcb314@...mail.com
Subject: Re:
 linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533:
 pointless test ?

On Mon, Aug 22, 2016 at 03:07:44PM +0100, David Binderman wrote:
> Hello there,
> 
> linux-4.8-rc3/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c:3533]:
> (style) Condition 'pBtMgnt.ExtConfig.HCIExtensionVer>=1' is always
> true
> 
> Source code is
> 
>         if (pBtMgnt->ExtConfig.HCIExtensionVer < 1) {
>         ....
>         } else if (pBtMgnt->ExtConfig.HCIExtensionVer >= 1) {
> 
> Suggest remove second test.

patches are always welcome :)