linux-kernel - Re: [PATCH tip/core/rcu 1/5] rcu: Fix soft lockup for rcu_nocb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c2d6fd58-5111-3cdc-1d80-9c98eeb6e54f@gmail.com>
Date:   Mon, 22 Aug 2016 19:19:53 +0300
From:   Nikolay Borisov <n.borisov.lkml@...il.com>
To:     "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Cc:     mingo@...nel.org, jiangshanlai@...il.com, dipankar@...ibm.com,
        akpm@...ux-foundation.org, mathieu.desnoyers@...icios.com,
        josh@...htriplett.org, tglx@...utronix.de, peterz@...radead.org,
        rostedt@...dmis.org, dhowells@...hat.com, edumazet@...gle.com,
        dvhart@...ux.intel.com, fweisbec@...il.com, oleg@...hat.com,
        bobby.prani@...il.com, Ding Tianhong <dingtianhong@...wei.com>
Subject: Re: [PATCH tip/core/rcu 1/5] rcu: Fix soft lockup for
 rcu_nocb_kthread


[SNIP]
> 
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
> [ paulmck: Substituted cond_resched_rcu_qs for cond_resched. ]

This contradicts...

> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> ---
>  kernel/rcu/tree_plugin.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 0082fce402a0..85c5a883c6e3 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -2173,6 +2173,7 @@ static int rcu_nocb_kthread(void *arg)
>  				cl++;
>  			c++;
>  			local_bh_enable();
> +			cond_resched_rcu_qs();

with what's here?
>  			list = next;
>  		}
>  		trace_rcu_batch_end(rdp->rsp->name, c, !!list, 0, 0, 1);
>