linux-kernel - RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <423FD6710FB8FB4F8728F93591889F9A15FA8E64@avsrvexchmbx1.microsemi.net>
Date:   Mon, 22 Aug 2016 18:00:28 +0000
From:   David Carroll <david.carroll@...rosemi.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "dl-esc-Aacraid Linux Driver" <aacraid@...rosemi.com>,
        "James E. J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Julia Lawall <julia.lawall@...6.fr>
Subject: RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating
 its implementation

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 20 Aug 2016 20:05:24 +0200
> 
> Reuse existing functionality from memdup_user() instead of keeping duplicate
> source code.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/scsi/aacraid/commctrl.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/scsi/aacraid/commctrl.c b/drivers/scsi/aacraid/commctrl.c
> index 5648b71..1af3084 100644
> --- a/drivers/scsi/aacraid/commctrl.c
> +++ b/drivers/scsi/aacraid/commctrl.c
> @@ -526,15 +526,9 @@ static int aac_send_raw_srb(struct aac_dev* dev, void
> __user * arg)
>                 goto cleanup;
>         }
> 
> -       user_srbcmd = kmalloc(fibsize, GFP_KERNEL);
> -       if (!user_srbcmd) {
> -               dprintk((KERN_DEBUG"aacraid: Could not make a copy of the srb\n"));
> -               rcode = -ENOMEM;
> -               goto cleanup;
> -       }
> -       if(copy_from_user(user_srbcmd, user_srb,fibsize)){
> -               dprintk((KERN_DEBUG"aacraid: Could not copy srb from user\n"));
> -               rcode = -EFAULT;
> +       user_srbcmd = memdup_user(user_srb, fibsize);
> +       if (IS_ERR(user_srbcmd)) {
> +               rcode = PTR_ERR(user_srbcmd);
>                 goto cleanup;
>         }
> 
> --

Hi Markus,

Patch 2/7 should precede Patch 1/7, as falling into kfree() would not look pretty.

Thanks, -Dave