linux-kernel - Re: [PATCH v05 05/72] hsi_char.h: use _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160822205432.44b2gu7ohaz3la5t@earth>
Date:   Mon, 22 Aug 2016 22:54:36 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Mikko Rapeli <mikko.rapeli@....fi>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v05 05/72] hsi_char.h: use __u32 from linux/types.h

Hi,

On Mon, Aug 22, 2016 at 08:32:22PM +0200, Mikko Rapeli wrote:
> Fixes userspace compiler errors like:
> 
> linux/hsi/hsi_char.h:51:2: error: unknown type name ‘uint32_t’
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>
> ---
>  include/uapi/linux/hsi/hsi_char.h | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/include/uapi/linux/hsi/hsi_char.h b/include/uapi/linux/hsi/hsi_char.h
> index 76160b4..c00a463 100644
> --- a/include/uapi/linux/hsi/hsi_char.h
> +++ b/include/uapi/linux/hsi/hsi_char.h
> @@ -20,10 +20,11 @@
>   * 02110-1301 USA
>   */
>  
> -
>  #ifndef __HSI_CHAR_H
>  #define __HSI_CHAR_H
>  
> +#include <linux/types.h>
> +
>  #define HSI_CHAR_MAGIC		'k'
>  #define HSC_IOW(num, dtype)	_IOW(HSI_CHAR_MAGIC, num, dtype)
>  #define HSC_IOR(num, dtype)	_IOR(HSI_CHAR_MAGIC, num, dtype)
> @@ -48,16 +49,16 @@
>  #define HSC_ARB_PRIO		1
>  
>  struct hsc_rx_config {
> -	uint32_t mode;
> -	uint32_t flow;
> -	uint32_t channels;
> +	__u32 mode;
> +	__u32 flow;
> +	__u32 channels;
>  };
>  
>  struct hsc_tx_config {
> -	uint32_t mode;
> -	uint32_t channels;
> -	uint32_t speed;
> -	uint32_t arb_mode;
> +	__u32 mode;
> +	__u32 channels;
> +	__u32 speed;
> +	__u32 arb_mode;
>  };
>  
>  #endif /* __HSI_CHAR_H */

Thanks, queued.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)