linux-kernel - Re: [PATCH] Input: tegra-kbc: fix inverted reset logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Aug 2016 14:20:06 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-input@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        linux-kernel@...r.kernel.org,
        Stephen Warren <swarren@...dotorg.org>,
        Rakesh Iyer <riyer@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        linux-tegra@...r.kernel.org, Alexandre Courbot <gnurou@...il.com>
Subject: Re: [PATCH] Input: tegra-kbc: fix inverted reset logic

On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote:
> Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> accidentally converted _deassert to _assert, so there is no code
> to wake up this hardware.
> 
> Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Applied, thank you.

> ---
> 
>  drivers/input/keyboard/tegra-kbc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index 7d61439..0c07e10 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
>  	/* Reset the KBC controller to clear all previous status.*/
>  	reset_control_assert(kbc->rst);
>  	udelay(100);
> -	reset_control_assert(kbc->rst);
> +	reset_control_deassert(kbc->rst);
>  	udelay(100);
>  
>  	tegra_kbc_config_pins(kbc);
> -- 
> 1.9.1
> 

-- 
Dmitry