linux-kernel - Re: [PATCH] acpi, nfit: check for the correct event code in notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4iw0ErHB-1yp+w4nd+7A5aVHXbieRq2ikR953UL4FBUVQ@mail.gmail.com>
Date:   Mon, 22 Aug 2016 15:43:22 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Vishal Verma <vishal.l.verma@...el.com>
Cc:     "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linda Knippers <linda.knippers@....com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Linux ACPI <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH] acpi, nfit: check for the correct event code in notifications

On Fri, Aug 19, 2016 at 1:40 PM, Vishal Verma <vishal.l.verma@...el.com> wrote:
> Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added
> support for _FIT notifications, but it neglected to verify the
> notification event code matches the one in the ACPI spec for
> "NFIT Update". Currently there is only one code in the spec, but
> once additional codes are added, older kernels (without this fix)
> will misbehave by assuming all event notifications are for an
> NFIT Update.
>
> Fixes: 209851649dc4 ("acpi: nfit: Add support for hot-add")
> Cc: <stable@...r.kernel.org>
> Cc: <linux-acpi@...r.kernel.org>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Reported-by: Linda Knippers <linda.knippers@....com>
> Signed-off-by: Vishal Verma <vishal.l.verma@...el.com>

Looks good to me.  Given the lead time of spec changes I think this
can wait for the 4.9 merge window.  I'll add it to the -next branch.