linux-kernel - Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ definition to hdlc/ioctl.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160822.163032.1005091075765531174.davem@davemloft.net>
Date:   Mon, 22 Aug 2016 16:30:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mikko.rapeli@....fi
Cc:     linux-kernel@...r.kernel.org, zhangshengju@...s.chinamobile.com
Subject: Re: [PATCH v05 27/72] linux/if.h linux/hdlc/ioctl.h: move IFNAMSIZ
 definition to hdlc/ioctl.h

From: Mikko Rapeli <mikko.rapeli@....fi>
Date: Mon, 22 Aug 2016 20:32:44 +0200

> Fixes userspace compiler error:
> 
> error: ‘IFNAMSIZ’ undeclared here (not in a function)
> 
> Suggested by Frans Klaver <fransklaver@...il.com> on lkml message
> <20150530195223.GA15645@...ger.home>.
> 
> Signed-off-by: Mikko Rapeli <mikko.rapeli@....fi>

IFNAMSIZ has to be in linux/if.h, you aren't explaining why you have
to move it to the hdlc header instead of having the hdlc header
include linux/if.h

And if your reason is legitimate, you have to add that explanation to
the patch commit log message.