linux-kernel - Re: [PATCH v7 4/8] Documentation: bindings: add dt documentation for dfi controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <57BBDDBF.8040105@samsung.com>
Date:   Tue, 23 Aug 2016 14:23:11 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Lin Huang <hl@...k-chips.com>, heiko@...ech.de,
        myungjoo.ham@...sung.com
Cc:     tixy@...aro.org, mark.rutland@....com, typ@...k-chips.com,
        linux-rockchip@...ts.infradead.org, airlied@...ux.ie,
        mturquette@...libre.com, dbasehore@...omium.org,
        sboyd@...eaurora.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, dianders@...omium.org,
        kyungmin.park@...sung.com, sudeep.holla@....com,
        linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        mark.yao@...k-chips.com
Subject: Re: [PATCH v7 4/8] Documentation: bindings: add dt documentation for
 dfi controller

Hi Lin,

On 2016년 08월 22일 12:36, Lin Huang wrote:
> This patch adds the documentation for rockchip dfi devfreq-event driver.
> 
> Signed-off-by: Lin Huang <hl@...k-chips.com>
> ---
> Changes in v7:
> -None
> 
> Changes in v6:
> -None
> 
> Changes in v5:
> -None
> 
> Changes in v4:
> -None
> 
> Changes in v3:
> -None
> 
> Changes in v2:
> -None 
> 
> Changes in v1:
> -None
>  .../bindings/devfreq/event/rockchip-dfi.txt          | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> 
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> new file mode 100644
> index 0000000..bf42255
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> @@ -0,0 +1,20 @@
> +
> +* Rockchip rk3399 DFI device
> +
> +Required properties:
> +- compatible: Must be "rockchip,rk3399-dfi".
> +- reg: physical base address of each DFI and length of memory mapped region
> +- rockchip,pmu: phandle to the syscon managing the "pmu general register files"
> +- clocks: phandles for clock specified in "clock-names" property
> +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon";
> +
> +Example:
> +	dfi: dfi@...f630000 {
> +		reg = <0x00 0xff630000 0x00 0x4000>;
> +		compatible = "rockchip,rk3399-dfi";
> +		rockchip,pmu = <&pmugrf>;
> +		clocks = <&cru PCLK_DDR_MON>;
> +		clock-names = "pclk_ddr_mon";
> +		status = "disabled";
> +	};
> +
> 

I reviewed this patch on previous version[1] already.
[1] https://lkml.org/lkml/2016/8/16/913

There are minor requirement. If you modify it,
I'll finish the review of this patch.

-- 
Best Regards,
Chanwoo Choi