linux-kernel - Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Aug 2016 12:01:36 +0530
From:   Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:     Ming-Chia Chung <quexint@...il.com>
Cc:     gregkh@...uxfoundation.org, shaun.ren@...ux.com,
        bhaktipriya96@...il.com, janani.rvchndrn@...il.com,
        bhumirks@...il.com, dilekuzulmez@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote:
> On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote:
> > On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote:
> > >   This patch fixes a minor checkpatch warnings:
> > > 
> > >   "WARNING: Block comments use a trailing */ on a separate line"
> > > 
> > >   Signed-off-by: Ming-Chia Chung <Quexint@...il.com>
> > > ---
> > >  drivers/staging/rts5208/rtsx.c | 42 ++++++++++++++++++++++++++++--------------
> > >  1 file changed, 28 insertions(+), 14 deletions(-)
> > > 
> > > diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> > > index e992e03..a880411 100644
> > > --- a/drivers/staging/rts5208/rtsx.c
> > > +++ b/drivers/staging/rts5208/rtsx.c
> > > @@ -81,14 +81,16 @@ static int slave_alloc(struct scsi_device *sdev)
> > >  
> > >  static int slave_configure(struct scsi_device *sdev)
> > >  {
> > > -	/* Scatter-gather buffers (all but the last) must have a length
> > > +	/*
> > > +   * Scatter-gather buffers (all but the last) must have a length
> > 
> > The alignment doesnot look correct here. Also in some more places later
> > in this patch.
> > 
> > regards
> > Sudip
> 
> I sent this patch by following docs ([1] and [2]). The style for long
> comments needs the begining and ending almost-blank lines. There is no
> the begining almost-blank line only for the files in net/ and
> drivers/net/.
> Please let me know what I misunderstood.

After applying the patch the file was like:
        /*
   * Scatter-gather buffers (all but the last) must have a length
         * divisible by the bulk maxpacket size.  Otherwise a data packet
         * would end up being short, causing a premature end to the data
         * transfer.  Since high-speed bulk pipes have a maxpacket size

See the alignment of the second line. Please use tab instead of space. And also
checkpatch should have warned you not to use space before the Signed-off-by.

regards
sudip