linux-kernel - Re: [PATCH 3/4] gpio: spear-spics: drop unused MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbGi29PCCgG2CtA4a_0f-6V2hNADMxb5Gtr3F8hvCXYuw@mail.gmail.com>
Date:   Tue, 23 Aug 2016 11:24:17 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Shiraz Hashim <shiraz.linux.kernel@...il.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH 3/4] gpio: spear-spics: drop unused MODULE_ tags from
 non-modular code

On Mon, Aug 22, 2016 at 6:48 PM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> drivers/gpio/Kconfig:config GPIO_SPEAR_SPICS
> drivers/gpio/Kconfig:   bool "ST SPEAr13xx SPI Chip Select as GPIO support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We delete the MODULE_LICENSE tag etc. since all that information
> is now contained at the top of the file in the comments.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Cc: Shiraz Hashim <shiraz.linux.kernel@...il.com>
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Patch applied.

Yours,
Linus Walleij