linux-kernel - Re: [PATCH] irqchip: mips-gic: Use for_each_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160823011317.GV3353@io.lakedaemon.net>
Date:   Tue, 23 Aug 2016 01:13:17 +0000
From:   Jason Cooper <jason@...edaemon.net>
To:     Paul Burton <paul.burton@...tec.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <marc.zyngier@....com>,
        linux-kernel@...r.kernel.org, linux-mips@...ux-mips.org
Subject: Re: [PATCH] irqchip: mips-gic: Use for_each_set_bit to iterate over
 IRQs

Hi Paul,

On Fri, Aug 19, 2016 at 06:11:19PM +0100, Paul Burton wrote:
> The MIPS GIC driver has previously iterated over bits set in a bitmap
> representing pending IRQs by calling find_first_bit, clearing that bit
> then calling find_first_bit again until all bits are clear. If multiple
> interrupts are pending then this is wasteful, as find_first_bit will
> have to loop over the whole bitmap from the start. Use the
> for_each_set_bit macro which performs exactly what we need here instead.
> It will use find_next_bit and thus only scan over the relevant part of
> the bitmap, and it makes the intent of the code clearer.
> 
> Signed-off-by: Paul Burton <paul.burton@...tec.com>
> ---
>  drivers/irqchip/irq-mips-gic.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Applied to irqchip/core.

thx,

Jason.