linux-kernel - Re: [PATCH 3/7] libfs: support RENAME_NOREPLACE in simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823144701.GA9798@kroah.com>
Date:   Tue, 23 Aug 2016 10:47:01 -0400
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Miklos Szeredi <mszeredi@...hat.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>,
        Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH 3/7] libfs: support RENAME_NOREPLACE in simple_rename()

On Tue, Aug 23, 2016 at 04:05:28PM +0200, Miklos Szeredi wrote:
> This is trivial to do:
> 
>  - add flags argument to simple_rename()
>  - check if flags doesn't have any other than RENAME_NOREPLACE
>  - assign simple_rename() to .rename2 instead of .rename
> 
> Filesystems converted:
> 
> hugetlbfs, ramfs, bpf.
> 
> Debugfs uses simple_rename() to implement debugfs_rename(), which is for
> debugfs instances to rename files internally, not for userspace filesystem
> access.  For this case pass zero flags to simple_rename().
> 
> Signed-off-by: Miklos Szeredi <mszeredi@...hat.com>
> Cc: Alexei Starovoitov <ast@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>