linux-kernel - Re: [PATCH 3/4] gpio: spear-spics: drop unused MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Aug 2016 00:19:28 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alexandre Courbot <gnurou@...il.com>,
        Shiraz Hashim <shiraz.linux.kernel@...il.com>,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH 3/4] gpio: spear-spics: drop unused MODULE_ tags from
 non-modular code

2016-08-23 1:48 GMT+09:00 Paul Gortmaker <paul.gortmaker@...driver.com>:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/gpio/Kconfig:config GPIO_SPEAR_SPICS
> drivers/gpio/Kconfig:   bool "ST SPEAr13xx SPI Chip Select as GPIO support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> We delete the MODULE_LICENSE tag etc. since all that information
> is now contained at the top of the file in the comments.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Alexandre Courbot <gnurou@...il.com>
> Cc: Shiraz Hashim <shiraz.linux.kernel@...il.com>
> Cc: linux-gpio@...r.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/gpio/gpio-spear-spics.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-spear-spics.c b/drivers/gpio/gpio-spear-spics.c
> index 7ffd16495286..22267479ba68 100644
> --- a/drivers/gpio/gpio-spear-spics.c
> +++ b/drivers/gpio/gpio-spear-spics.c
> @@ -12,7 +12,7 @@
>  #include <linux/err.h>
>  #include <linux/gpio.h>
>  #include <linux/io.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
>  #include <linux/types.h>

Please keep the includes sorted alphabetically,
i.e. <linux/init.h> above <linux/io.h>.

I was a little late, though.



-- 
Best Regards
Masahiro Yamada