linux-kernel - Re: [PATCH 4/7] fs: make remaining filesystems use .rename2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28724.1471966583@warthog.procyon.org.uk>
Date:   Tue, 23 Aug 2016 16:36:23 +0100
From:   David Howells <dhowells@...hat.com>
To:     Miklos Szeredi <mszeredi@...hat.com>
Cc:     dhowells@...hat.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
        Eric Van Hensbergen <ericvh@...il.com>,
        Ilya Dryomov <idryomov@...il.com>,
        Jan Harkes <jaharkes@...cmu.edu>,
        Tyler Hicks <tyhicks@...onical.com>,
        Boaz Harrosh <ooo@...ctrozaur.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Oleg Drokin <oleg.drokin@...el.com>,
        Trond Myklebust <trond.myklebust@...marydata.com>,
        Mark Fasheh <mfasheh@...e.com>,
        Mike Marshall <hubcap@...ibond.com>
Subject: Re: [PATCH 4/7] fs: make remaining filesystems use .rename2

Miklos Szeredi <mszeredi@...hat.com> wrote:

> This is trivial to do:
> 
>  - add flags argument to foo_rename()
>  - check if flags is zero
>  - assign foo_rename() to .rename2 instead of .rename
> 
> This doesn't mean it's impossible to support RENAME_NOREPLACE for these
> filesystems, but it is not trivial, like for local filesystems.
> RENAME_NOREPLACE must guarantee atomicity (i.e. it shouldn't be possible
> for a file to be created on one host while it is overwritten by rename on
> another host).
> 
> Filesystems converted:
> 
> 9p, afs, ceph, coda, ecryptfs, exofs, kernfs, lustre, ncpfs, nfs, ocfs2,
> orangefs.
> 
> After this, we can get rid of the duplicate interfaces for rename.
> 
> Signed-off-by: Miklos Szeredi <mszeredi@...hat.com>
> Cc: Eric Van Hensbergen <ericvh@...il.com>
> Cc: Ilya Dryomov <idryomov@...il.com>
> Cc: Jan Harkes <jaharkes@...cmu.edu>
> Cc: Tyler Hicks <tyhicks@...onical.com>
> Cc: Boaz Harrosh <ooo@...ctrozaur.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Oleg Drokin <oleg.drokin@...el.com>
> Cc: Trond Myklebust <trond.myklebust@...marydata.com>
> Cc: Mark Fasheh <mfasheh@...e.com>
> Cc: Mike Marshall <hubcap@...ibond.com>

Acked-by: David Howells <dhowells@...hat.com> [AFS]