linux-kernel - Re: [PATCH v7 6/7] power: act8945a_charger: Add max current property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823024351.akwvobxzvwwhzwsq@earth>
Date:   Tue, 23 Aug 2016 04:43:51 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Wenyou Yang <wenyou.yang@...el.com>
Cc:     Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Pawel Moll <pawel.moll@....com>,
        Mark Brown <broonie@...nel.org>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        Kumar Gala <galak@...eaurora.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Nicolas Ferre <nicolas.ferre@...el.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v7 6/7] power: act8945a_charger: Add max current property

Hi,

On Mon, Aug 22, 2016 at 02:49:16PM +0800, Wenyou Yang wrote:
> [...]
>
> -	chglev_pin = of_get_named_gpio_flags(np,
> -				"active-semi,chglev-gpios", 0, &flags);
> -
> -	if (gpio_is_valid(chglev_pin)) {
> -		gpio_set_value(chglev_pin,
> -			       ((flags == OF_GPIO_ACTIVE_LOW) ? 0 : 1));
> +	charger->chglev_gpio = gpiod_get(dev->parent,
> +					 "active-semi,chglev", GPIOD_IN);
> +	if (PTR_ERR(charger->chglev_gpio) == -EPROBE_DEFER) {
> +		dev_info(dev, "probe retry requested for gpio \"chglev\"\n");

missing return? You need to return EPROBE_DEFER in probe().

> +	} else if (IS_ERR(charger->chglev_gpio)) {
> +		dev_err(dev, "unable to claim gpio \"chglev\"\n");
> +		charger->chglev_gpio = NULL;
>  	}
>  
> [...]

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)