linux-kernel - Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b9111f3-1c9d-f551-af06-566adceaef38@gmail.com>
Date:   Wed, 24 Aug 2016 00:43:07 +0800
From:   Wei Yongjun <weiyj.lk@...il.com>
To:     Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:     Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c

Hi Robert,
 

On 08/24/2016 12:24 AM, Robert Jarzmik wrote:
> Wei Yongjun <weiyj.lk@...il.com> writes:
>
>> Remove duplicated include.
> How so duplicated ? Can you elaborate please ?
>
> Moreover, how do you do think symbol_get() can stay in spitz.c without having
> this include ?

file linux/module.h included twice as following:

#include <linux/kernel.h>
#include <linux/module.h>       /* symbol_get ; symbol_put */
...
#include <linux/module.h>

So I think we can remove the dup include.

Regards,
Wei Yongjun