linux-kernel - Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMGZ=HSQqObOd6Q6hKVgXFy+EVfeNj8FH2JFs+az4i5hxUJiQ@mail.gmail.com>
Date:   Tue, 23 Aug 2016 19:15:10 +0200
From:   Vegard Nossum <vegard.nossum@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Luis Henriques <luis.henriques@...onical.com>,
        Avijit Kanti Das <avijitnsec@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        Ben Hutchings <ben@...adent.org.uk>,
        Linux Netdev List <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: net: Zeroing the structure ethtool_wolinfo in ethtool_get_wol()

On 23 August 2016 at 17:05, Joe Perches <joe@...ches.com> wrote:
> On Tue, 2016-08-23 at 07:21 -0700, Eric Dumazet wrote:
>> On Tue, 2016-08-23 at 14:41 +0100, Luis Henriques wrote:
>> > From: Avijit Kanti Das <avijitnsec@...eaurora.org>
>> >
>> > memset() the structure ethtool_wolinfo that has padded bytes
>> > but the padded bytes have not been zeroed out.
> []
>> > diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> []
>> > @@ -1435,11 +1435,13 @@ static int ethtool_reset(struct net_device *dev, char __user *useraddr)
>> >
>> >  static int ethtool_get_wol(struct net_device *dev, char __user *useraddr)
>> >  {
>> > -   struct ethtool_wolinfo wol = { .cmd = ETHTOOL_GWOL };
>> > +   struct ethtool_wolinfo wol;
>> >
>> >     if (!dev->ethtool_ops->get_wol)
>> >             return -EOPNOTSUPP;
>> >
>> > +   memset(&wol, 0, sizeof(struct ethtool_wolinfo));
>> > +   wol.cmd = ETHTOOL_GWOL;
>> >     dev->ethtool_ops->get_wol(dev, &wol);
>> >
>> >     if (copy_to_user(useraddr, &wol, sizeof(wol)))
>> This would suggest a compiler bug to me.
>
> A compiler does not have a standards based requirement to
> initialize arbitrary padding bytes.
>
> I believe gcc always does zero all padding anyway.
>
>> I checked that my compiler does properly put zeros there, even in the
>> padding area.
>>
>> If we can not rely on such constructs, we have hundreds of similar
>> patches to submit.
>
> True.
>
> From a practical point of view, does any compiler used for
> kernel compilation (gcc/icc/llvm/any others?) not always
> perform zero padding of alignment bytes?
>

gcc often does not do it, depends on a few factors though:

https://lkml.org/lkml/2016/5/20/389


Vegard