linux-kernel - Re: [PATCH v2] pwm: add pwm driver for HiSilicon BVT SOCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823180812.GA2793@rob-hp-laptop>
Date:   Tue, 23 Aug 2016 13:08:12 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jian Yuan <yuanjian12@...ilicon.com>
Cc:     thierry.reding@...il.com, mark.rutland@....com,
        linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, xuejiancheng@...ilicon.com,
        kevin.lixu@...ilicon.com, jalen.hsu@...ilicon.com
Subject: Re: [PATCH v2] pwm: add pwm driver for HiSilicon BVT SOCs

On Mon, Aug 22, 2016 at 03:50:13PM +0800, Jian Yuan wrote:
> From: yuanjian <yuanjian12@...ilicon.com>
> 
> Add pwm driver for HiSilicon BVT SOCs
> 
> Reviewed-by: Jiancheng Xue <xuejiancheng@...ilicon.com>
> Signed-off-by: Jian Yuan <yuanjian12@...ilicon.com>
> ---
> Change Log:
> v2:
> The number of PWMs is change to be probeable based on the compatible string.
> 
>  .../devicetree/bindings/pwm/pwm-hibvt.txt          |  18 ++

For the binding:

Acked-by: Rob Herring <robh@...nel.org>

One comment though...

>  drivers/pwm/Kconfig                                |  10 +
>  drivers/pwm/Makefile                               |   1 +
>  drivers/pwm/pwm-hibvt.c                            | 274 +++++++++++++++++++++
>  4 files changed, 303 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-hibvt.txt
>  create mode 100644 drivers/pwm/pwm-hibvt.c

> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index c182efc..3c48768 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -158,6 +158,15 @@ config PWM_FSL_FTM
>  	  To compile this driver as a module, choose M here: the module
>  	  will be called pwm-fsl-ftm.
>  
> +config PWM_HIBVT
> +	tristate "HiSilicon BVT PWM support"
> +	depends on ARCH_HISI

Add "|| COMPILE_TEST" so it can build test on other configs

> +	help
> +	  Generic PWM framework driver for hisilicon BVT SOCs.
> +