linux-kernel - Re: [PATCH 2/4] ARM: dts: exynos: Use 'hpd-gpios' instead of 'hpd-gpio'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Aug 2016 15:10:44 -0500
From:   Rob Herring <robh@...nel.org>
To:     Milo Kim <woogyom.kim@...il.com>
Cc:     Inki Dae <inki.dae@...sung.com>,
        Joonyoung Shim <jy0922.shim@...sung.com>,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 2/4] ARM: dts: exynos: Use 'hpd-gpios' instead of
 'hpd-gpio'

On Tue, Aug 23, 2016 at 06:13:37PM +0900, Milo Kim wrote:
> This patch enables getting a HPD GPIO descriptor quickly.
> The exynos-hdmi driver uses "hpd" for HDMI hot plug detection.
> 
> 	static int hdmi_resources_init(struct hdmi_context *hdata)
> 	{
> 		...
> 		hdata->hpd_gpio = devm_gpiod_get(dev, "hpd", GPIOD_IN);
> 		...
> 	}
> 
> This calls 'of_find_gpio()' and it generates the GPIO consumer ID by referring
> GPIO suffix. So 'hpd-gpios' is preferred on getting a GPIO descriptor.
> 
> However, if the device tree uses 'hpd-gpio', then the exynos-hdmi driver
> always retries to get a GPIO descriptor because the first GPIO suffix is not
> 'gpio' but 'gpios'. So you always see the debug message below.
> 
> 	of_get_named_gpiod_flags: can't parse 'hpd-gpios' property of node '/soc/hdmi@...30000[0]'
> 
> Use the preferred property, 'hpd-gpios' instead of 'hpd-gpio'.
> 
> Cc: Inki Dae <inki.dae@...sung.com>
> Cc: Joonyoung Shim <jy0922.shim@...sung.com>
> Cc: Seung-Woo Kim <sw0312.kim@...sung.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: devicetree@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-samsung-soc@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Milo Kim <woogyom.kim@...il.com>
> ---
>  Documentation/devicetree/bindings/display/exynos/exynos_hdmi.txt | 4 ++--
>  arch/arm/boot/dts/exynos4210-universal_c210.dts                  | 2 +-
>  arch/arm/boot/dts/exynos4412-odroid-common.dtsi                  | 2 +-
>  arch/arm/boot/dts/exynos5250-arndale.dts                         | 2 +-
>  arch/arm/boot/dts/exynos5250-smdk5250.dts                        | 2 +-
>  arch/arm/boot/dts/exynos5250-snow-common.dtsi                    | 2 +-
>  arch/arm/boot/dts/exynos5250-spring.dts                          | 2 +-
>  arch/arm/boot/dts/exynos5420-peach-pit.dts                       | 2 +-
>  arch/arm/boot/dts/exynos5420-smdk5420.dts                        | 2 +-
>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi               | 2 +-
>  arch/arm/boot/dts/exynos5800-peach-pi.dts                        | 2 +-
>  11 files changed, 12 insertions(+), 12 deletions(-)

Acked-by: Rob Herring <robh@...nel.org>