linux-kernel - Re: [PATCH v05 47/72] include/uapi/linux/coda.h: use __kernel_pid_t and add u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823205308.GR5399@lakka.kapsi.fi>
Date:   Tue, 23 Aug 2016 23:53:08 +0300
From:   Mikko Rapeli <mikko.rapeli@....fi>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Jan Harkes <jaharkes@...cmu.edu>, coda@...cmu.edu,
        codalist@...a.cs.cmu.edu
Subject: Re: [PATCH v05 47/72] include/uapi/linux/coda.h: use __kernel_pid_t
 and add u_short etc definitions for userspace

On Tue, Aug 23, 2016 at 11:08:06AM +0800, kbuild test robot wrote:
> Hi Mikko,
> 
> [auto build test ERROR on linus/master]
> [also build test ERROR on v4.8-rc3]
> [cannot apply to next-20160822]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> [Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
> [Check https://git-scm.com/docs/git-format-patch for more information]
> 
> url:    https://github.com/0day-ci/linux/commits/Mikko-Rapeli/Userspace-compile-test-and-fixes-for-exported-uapi-header-files/20160823-034928
> config: x86_64-randconfig-v0-08230740 (attached as .config)
> compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/coda.h:64,
>                     from fs/coda/psdev.c:45:
> >> include/uapi/linux/coda.h:103: error: redefinition of typedef 'u_long'
>    include/linux/types.h:86: note: previous declaration of 'u_long' was here
> >> include/uapi/linux/coda.h:104: error: redefinition of typedef 'u_int'
>    include/linux/types.h:85: note: previous declaration of 'u_int' was here
> >> include/uapi/linux/coda.h:105: error: redefinition of typedef 'u_short'
>    include/linux/types.h:84: note: previous declaration of 'u_short' was here
> >> include/uapi/linux/coda.h:106: error: redefinition of typedef 'ino_t'
>    include/linux/types.h:16: note: previous declaration of 'ino_t' was here
> 
> vim +/u_long +103 include/uapi/linux/coda.h
> 
>     97	#endif /* !DJGPP */
>     98	
>     99	
>    100	#if defined(__linux__)
>    101	#include <linux/time.h>
>    102	#define cdev_t u_quad_t
>  > 103	typedef unsigned long u_long;
>  > 104	typedef unsigned int u_int;
>  > 105	typedef unsigned short u_short;
>  > 106	typedef u_long ino_t;

Thanks! I'll move these to #ifndef __KERNEL__ side and try to detect if
they are already defined by userspace headers.

-Mikko

>    107	
>    108	#ifndef __KERNEL__
>    109	typedef u_long dev_t;
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation