linux-kernel - Re: [PATCH 3/3] Input: wm97xx: Remove deprecated create_singletheread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823210133.GF6712@dtor-ws>
Date:   Tue, 23 Aug 2016 14:01:33 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Bhaktipriya Shridhar <bhaktipriya96@...il.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Pali Rohár <pali.rohar@...il.com>,
        Chris Diamand <chris@...mand.org>,
        Stefan Assmann <sassmann@...nic.de>,
        Richard Pospesel <pospeselr@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Takashi Iwai <tiwai@...e.de>, Tejun Heo <tj@...nel.org>,
        patches@...nsource.wolfsonmicro.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Input: wm97xx: Remove deprecated
 create_singletheread_workqueue

On Sun, Aug 14, 2016 at 10:56:38AM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion. The workqueue "ts_workq" has been identity converted.
> 
> It queues work items viz &wm->ts_reader and &wm->pen_event_work which map
> to wm97xx_pen_irq_worker (handles a pen down interrupt) and
> wm97xx_ts_reader (the touchscreen sample reader) respectively. Hence,
> an ordered dedicated workqueue has been used.
> 
> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> pressure.
> 
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/wm97xx-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
> index 1534e9b..c0af844 100644
> --- a/drivers/input/touchscreen/wm97xx-core.c
> +++ b/drivers/input/touchscreen/wm97xx-core.c
> @@ -500,7 +500,7 @@ static int wm97xx_ts_input_open(struct input_dev *idev)
>  {
>  	struct wm97xx *wm = input_get_drvdata(idev);
> 
> -	wm->ts_workq = create_singlethread_workqueue("kwm97xx");
> +	wm->ts_workq = alloc_ordered_workqueue("kwm97xx", WQ_MEM_RECLAIM);
>  	if (wm->ts_workq == NULL) {
>  		dev_err(wm->dev,
>  			"Failed to create workqueue\n");
> --
> 2.1.4
> 

-- 
Dmitry