linux-kernel - Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160823215247.GD28936@hardcore>
Date:   Tue, 23 Aug 2016 23:52:47 +0200
From:   Jan Glauber <jan.glauber@...iumnetworks.com>
To:     Wolfram Sang <wsa@...-dreams.de>
CC:     <linux-kernel@...r.kernel.org>, <linux-i2c@...r.kernel.org>,
        David Daney <ddaney@...iumnetworks.com>,
        <Steven.Hill@...iumnetworks.com>
Subject: Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support

On Tue, Aug 23, 2016 at 11:39:48PM +0200, Wolfram Sang wrote:
> On Tue, Aug 23, 2016 at 11:28:59PM +0200, Jan Glauber wrote:
> > On Tue, Aug 23, 2016 at 10:57:25PM +0200, Wolfram Sang wrote:
> > > On Wed, Jun 15, 2016 at 03:51:30PM +0200, Jan Glauber wrote:
> > > > Add SMBUS alert interrupt support. For now only device tree is
> > > > supported for specifying the alert. In case of ACPI an error
> > > > is returned.
> > > > 
> > > > Signed-off-by: Jan Glauber <jglauber@...ium.com>
> > > 
> > > What about 'select I2C_SMBUS' in Kconfig and skip all the ifdeffery?
> > > 
> > 
> > Wouldn't that prevent a distribution that has I2C_HELPER_AUTO set
> > from enabling the ThunderX i2c driver at all?
> 
> From commit e2ca307439fb9df922c3e8891289a2ac05812fb7:
> 
> ...
> Bus drivers which implement SMBus alert should select this option, so
> in most cases this option is hidden and the user doesn't have to care
> about it.
> 

OK, makes sense. I'll remove the ifdef's.