linux-kernel - Re: [PATCH v2 4/4] gpu: drm: exynos_hdmi: Use consolidated function on binding PHY DT property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <ce59db15-d128-ae4e-fce2-6d18b36ce878@samsung.com>
Date:   Wed, 24 Aug 2016 07:58:51 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Milo Kim <woogyom.kim@...il.com>, Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <k.kozlowski@...sung.com>,
        David Airlie <airlied@...ux.ie>
Cc:     devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 4/4] gpu: drm: exynos_hdmi: Use consolidated function on
 binding PHY DT property

On 08/24/2016 04:25 AM, Milo Kim wrote:
> Handle legacy and raw 'phy' parsing in single function.
> And it also removes goto condition.
>
> Cc: Kukjin Kim <kgene@...nel.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@...sung.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Inki Dae <inki.dae@...sung.com>
> Cc: Joonyoung Shim <jy0922.shim@...sung.com>
> Cc: Seung-Woo Kim <sw0312.kim@...sung.com>
> Cc: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: devicetree@...r.kernel.org
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-samsung-soc@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Signed-off-by: Milo Kim <woogyom.kim@...il.com>
> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 6a636f2..bb2d6d4 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1778,11 +1778,22 @@ static struct device_node *hdmi_ddc_dt_binding(struct device *dev)
>  	return np;
>  }
>  
> -static struct device_node *hdmi_legacy_phy_dt_binding(struct device *dev)
> +static struct device_node *hdmi_phy_dt_binding(struct device *dev)
>  {
>  	const char *compatible_str = "samsung,exynos4212-hdmiphy";
> +	struct device_node *np;
> +
> +	np = of_find_compatible_node(NULL, NULL, compatible_str);
> +	if (np)
> +		return np;
> +
> +	np = of_parse_phandle(dev->of_node, "phy", 0);
> +	if (!np)
> +		return NULL;
> +
> +	of_node_put(dev->of_node);

Identical issue as in previous patch.

Regards
Andrzej

>  
> -	return of_find_compatible_node(NULL, NULL, compatible_str);
> +	return np;
>  }
>  
>  static int hdmi_probe(struct platform_device *pdev)
> @@ -1829,19 +1840,13 @@ static int hdmi_probe(struct platform_device *pdev)
>  		return -EPROBE_DEFER;
>  	}
>  
> -	phy_node = hdmi_legacy_phy_dt_binding(dev);
> -	if (phy_node)
> -		goto out_get_phy_port;
> -
> -	phy_node = of_parse_phandle(dev->of_node, "phy", 0);
> +	phy_node = hdmi_phy_dt_binding(dev);
>  	if (!phy_node) {
>  		DRM_ERROR("Failed to find hdmiphy node in device tree\n");
>  		ret = -ENODEV;
>  		goto err_ddc;
>  	}
> -	of_node_put(dev->of_node);
>  
> -out_get_phy_port:
>  	if (hdata->drv_data->is_apb_phy) {
>  		hdata->regs_hdmiphy = of_iomap(phy_node, 0);
>  		if (!hdata->regs_hdmiphy) {