linux-kernel - Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function on binding DDC DT property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d5bf0cd-44f1-2028-7831-6828e43984d1@gmail.com>
Date:   Wed, 24 Aug 2016 16:21:28 +0900
From:   Milo Kim <woogyom.kim@...il.com>
To:     Andrzej Hajda <a.hajda@...sung.com>,
        David Airlie <airlied@...ux.ie>
Cc:     Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <k.kozlowski@...sung.com>,
        devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        Seung-Woo Kim <sw0312.kim@...sung.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/4] gpu: drm: exynos_hdmi: Use consolidated function
 on binding DDC DT property

Hi Andrzej,

On 08/24/2016 02:55 PM, Andrzej Hajda wrote:
> This is mistake introduced  by other patch, of_node_put should be called on
> np, after calling of_find_i2c_adapter_by_node. You can fix it in your
> patch as well.
> I think you can move of_find_i2c_adapter_by_node also to this function and
> rename it to sth like hdmi_get_ddc_adapter, this way you will enclose
> whole logic
> of getting resource into one function.

Agree, let me prepare next patch-set. Thanks!

Best regards,
Milo