linux-kernel - Re: [RFC v4 16/22] clockevents: use ->min_delta_ticks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r39eikhu.fsf@gmail.com>
Date:   Wed, 24 Aug 2016 11:28:29 +0200
From:   Nicolai Stange <nicstange@...il.com>
To:     Nicolai Stange <nicstange@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        John Stultz <john.stultz@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC v4 16/22] clockevents: use ->min_delta_ticks_adjusted to program minimum delta

>  static int clockevents_program_min_delta(struct clock_event_device *dev)
>  {
> -	unsigned long long clc;
> -	int64_t delta;
> -
> -	delta = dev->min_delta_ns;
> -
>  	if (clockevent_state_shutdown(dev))
>  		return 0;
>  
>  	dev->retries++;
> -	clc = ((unsigned long long) delta * dev->mult) >> dev->shift;
> -	return dev->set_next_event((unsigned long) clc, dev);
> +	return dev->set_next_event(dev->min_delta_ticks_incr, dev);
>  }
>  
>  #endif /* CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST */

FYI, the kernel build test robot reported a build failure with
CONFIG_GENERIC_CLOCKEVENTS_MIN_ADJUST=n. It shoud read as
dev->min_delta_ticks_adjusted here. In order to avoid unnecessary
traffic, I'll only fix this up in a v5 if you give the whole thing a go.