linux-kernel - Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Aug 2016 18:58:11 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     LABBE Corentin <clabbe.montjoie@...il.com>
Cc:     mpm@...enic.com, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name

On Fri, Aug 19, 2016 at 03:42:55PM +0200, LABBE Corentin wrote:
> The driver name is displayed each time differently.
> This patch make use of the same name everywhere.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
> ---
>  drivers/char/hw_random/amd-rng.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c
> index d0042f5..d0a806a 100644
> --- a/drivers/char/hw_random/amd-rng.c
> +++ b/drivers/char/hw_random/amd-rng.c
> @@ -31,7 +31,7 @@
>  #include <linux/delay.h>
>  #include <asm/io.h>
>  
> -#define PFX	KBUILD_MODNAME ": "
> +#define DRV_NAME "AMD768-HWRNG"
>  
>  /*
>   * Data for PCI driver interface
> @@ -98,7 +98,7 @@ static void amd_rng_cleanup(struct hwrng *rng)
>  }
>  
>  static struct hwrng amd_rng = {
> -	.name		= "amd",
> +	.name		= DRV_NAME,

Hmm, this changes a sysfs-exported name which has the potential
to break user-space.  So I think you'd need to a stronger argument
to do it other than just cleaning it up.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt