linux-kernel - Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160824123534.GB3714@ulmo.ba.sec>
Date:   Wed, 24 Aug 2016 14:35:34 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Vinay Simha <simhavcs@...il.com>
Cc:     Archit Taneja <archit.taneja@...il.com>,
        John Stultz <john.stultz@...aro.org>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        David Airlie <airlied@...ux.ie>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel
 bindings

On Wed, Aug 24, 2016 at 05:53:00PM +0530, Vinay Simha wrote:
> if we do not set the polarity to 8mA, panel will have gibberish display.
> (information to set 8mA is available only in
> nexus7-msm-flo-3.4-lollipop-release_dsi kernel nx7 release)
> 
> i will add this
> reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;

I don't think that will work with the current driver, because the GPIO
subsystem will automatically invert the value for you. Currently the
panel driver sets the GPIO value to 0 to assert the reset. With the
GPIO_ACTIVE_LOW flag you'd end up setting the actual level of the GPIO
to high, which is going to deassert. So I think if you make the above
change (which I think is the right thing to do), you'll also have to
update the driver to use high-active logic.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)