linux-kernel - Re: [PATCH v2 2/8] hisi_sas: add internal abort in hisi_sas_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <afdb313c-c621-da26-ae3a-7b0666274dd5@suse.de>
Date:   Wed, 24 Aug 2016 14:41:54 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linuxarm@...wei.com, zhangfei.gao@...aro.org, xuwei5@...ilicon.com,
        john.garry2@...l.dcu.ie, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/8] hisi_sas: add internal abort in
 hisi_sas_dev_gone()

On 08/24/2016 01:05 PM, John Garry wrote:
> Execute an internal abort for that device when it is removed,
> so that commands for that device are not processed.
> 
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
>  drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 763c6c5..c4e59cd 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -621,6 +621,9 @@ static void hisi_sas_dev_gone(struct domain_device *device)
>  	dev_info(dev, "found dev[%lld:%x] is gone\n",
>  		 sas_dev->device_id, sas_dev->dev_type);
>  
> +	hisi_sas_internal_task_abort(hisi_hba, device,
> +				     HISI_SAS_INT_ABT_DEV, 0);
> +
>  	hisi_hba->hw->free_device(hisi_hba, sas_dev);
>  	device->lldd_dev = NULL;
>  	memset(sas_dev, 0, sizeof(*sas_dev));
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)