linux-kernel - Re: [PATCH net] dwc_eth_qos: fix interrupt enable race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160823.171241.1929468036153832657.davem@davemloft.net>
Date:   Tue, 23 Aug 2016 17:12:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lars.persson@...s.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        rabinv@...s.com, larper@...s.com
Subject: Re: [PATCH net] dwc_eth_qos: fix interrupt enable race

From: Lars Persson <lars.persson@...s.com>
Date: Tue, 23 Aug 2016 16:31:28 +0200

> From: Rabin Vincent <rabinv@...s.com>
> 
> We currently enable interrupts before we enable NAPI. If an RX interrupt
> hits before we enabled NAPI then the NAPI callback is never called and
> we leave the hardware with RX interrupts disabled, which of course leads
> us to never handling received packets.  Fix this by moving the interrupt
> enable to after we've enable NAPI and the reclaim tasklet.
> 
> Fixes: cd5e41234729 ("dwc_eth_qos: do phy_start before resetting hardware")
> Signed-off-by: Rabin Vincent <rabinv@...s.com>
> Signed-off-by: Lars Persson <larper@...s.com>

Applied.