linux-kernel - Re: [PATCH -next] sound: rockchip: fix build when SPI is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 24 Aug 2016 10:55:08 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     LKML <linux-kernel@...r.kernel.org>,
        moderated for non-subscribers <alsa-devel@...a-project.org>,
        Takashi Iwai <tiwai@...e.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Bard Liao <bardliao@...ltek.com>,
        Oder Chiou <oder_chiou@...ltek.com>
Subject: Re: [PATCH -next] sound: rockchip: fix build when SPI is not enabled

On 08/22/16 11:32, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix build errors found in rt5514 drivers when SPI is not enabled.
> 
> Fixes these build errors:
> ERROR: "__spi_register_driver" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
> ERROR: "spi_sync" [sound/soc/codecs/snd-soc-rt5514-spi.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc:	Bard Liao <bardliao@...ltek.com>
> Cc:	Oder Chiou <oder_chiou@...ltek.com>
> ---
>  sound/soc/rockchip/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This builds without errors, but if you always want to have the SPI
> interface available in this driver, change the first "depends" to
> include "&& SPI_MASTER".

Please drop this patch.  The comment above is the correct thing to do
and I am sending a patch with that change.


> --- linux-next-20160822.orig/sound/soc/rockchip/Kconfig
> +++ linux-next-20160822/sound/soc/rockchip/Kconfig
> @@ -49,7 +49,7 @@ config SND_SOC_RK3399_GRU_SOUND
>  	select SND_SOC_MAX98357A
>  	select SND_SOC_RT5514
>  	select SND_SOC_DA7219
> -	select SND_SOC_RT5514_SPI
> +	select SND_SOC_RT5514_SPI if SPI_MASTER
>  	help
>  	  Say Y or M here if you want to add support multiple codecs for SoC
>  	  audio on Rockchip RK3399 GRU boards.
> 


-- 
~Randy