linux-kernel - Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57BDCE58.20200@cavium.com>
Date:   Wed, 24 Aug 2016 11:42:00 -0500
From:   "Steven J. Hill" <Steven.Hill@...ium.com>
To:     Aaro Koskinen <aaro.koskinen@....fi>,
        David Daney <ddaney@...iumnetworks.com>,
        Jon Hunter <jonathanh@...dia.com>,
        Rob Herring <robh@...nel.org>
CC:     <devicetree@...r.kernel.org>, <linux-mips@...ux-mips.org>,
        <linux-kernel@...r.kernel.org>,
        Thorsten Leemhuis <regressions@...mhuis.info>
Subject: Re: [BISECTED REGRESSION] v4.8-rc: gpio-leds broken on OCTEON

On 08/23/2016 03:36 PM, Aaro Koskinen wrote:
> Hi,
>
> gpio-leds fails to probe on OCTEON with v4.8-rc3 and when using
> arch/mips/boot/dts/cavium-octeon/dlink_dsr-1000n.dts. Leds still
> worked with v4.7.
>
> I bisected this to:
>
> 	commit 15cc2ed6dcf91a8658e084be4e140147161819d7
> 	Author: Jon Hunter <jonathanh@...dia.com>
> 	Date:   Mon Jun 20 14:49:18 2016 +0100
>
> 	of/irq: Mark initialised interrupt controllers as populated
>
> I have no idea how this is related to gpio-leds, except that on OCTEON
> DTBs the gpio node is also interrupt controller...
>
Hey Aaro.

It is actually two patches that cause the breakage. The other is:

    commit e55aeb6ba4e8cc3549bff1e75ea1d029324bce21
    of/irq: Mark interrupt controllers as populated before initialisation

I needed to revert both of these in order to get MMC working on our 71xx 
and 78xx boards. For our MMC, I got error messages from the MMC core of 
"Invalid POWER GPIO" until I applied the second patch. I will have a fix 
worthy of upstreaming today which will be posted today.

Steve