linux-kernel - Re: [PATCH 4.7 146/186] floppy: fix open(O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160824201701.GB2133@kroah.com>
Date:   Wed, 24 Aug 2016 16:17:01 -0400
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mark Hounschell <markh@...pro.net>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Wim Osterholt <wim@....tudelft.nl>,
        Jiri Kosina <jkosina@...e.cz>, Jens Axboe <axboe@...com>
Subject: Re: [PATCH 4.7 146/186] floppy: fix open(O_ACCMODE) for ioctl-only
 open

On Wed, Aug 24, 2016 at 09:34:44AM -0400, Mark Hounschell wrote:
> On 08/18/2016 09:59 AM, Greg Kroah-Hartman wrote:
> > 4.7-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Jiri Kosina <jkosina@...e.cz>
> > 
> > commit ff06db1efb2ad6db06eb5b99b88a0c15a9cc9b0e upstream.
> > 
> > Commit 09954bad4 ("floppy: refactor open() flags handling"), as a
> > side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that
> > this is being used setfdprm userspace for ioctl-only open().
> > 
> > Reintroduce back the original behavior wrt !(FMODE_READ|FMODE_WRITE)
> > modes, while still keeping the original O_NDELAY bug fixed.
> > 
> > Reported-by: Wim Osterholt <wim@....tudelft.nl>
> > Tested-by: Wim Osterholt <wim@....tudelft.nl>
> > Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> > Signed-off-by: Jens Axboe <axboe@...com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > ---
> >  drivers/block/floppy.c |   21 +++++++++------------
> >  1 file changed, 9 insertions(+), 12 deletions(-)
> > 
> > --- a/drivers/block/floppy.c
> > +++ b/drivers/block/floppy.c
> > @@ -3663,11 +3663,6 @@ static int floppy_open(struct block_devi
> > 
> >  	opened_bdev[drive] = bdev;
> > 
> > -	if (!(mode & (FMODE_READ|FMODE_WRITE))) {
> > -		res = -EINVAL;
> > -		goto out;
> > -	}
> > -
> >  	res = -ENXIO;
> > 
> >  	if (!floppy_track_buffer) {
> > @@ -3711,13 +3706,15 @@ static int floppy_open(struct block_devi
> >  	if (UFDCS->rawcmd == 1)
> >  		UFDCS->rawcmd = 2;
> > 
> > -	UDRS->last_checked = 0;
> > -	clear_bit(FD_OPEN_SHOULD_FAIL_BIT, &UDRS->flags);
> > -	check_disk_change(bdev);
> > -	if (test_bit(FD_DISK_CHANGED_BIT, &UDRS->flags))
> > -		goto out;
> > -	if (test_bit(FD_OPEN_SHOULD_FAIL_BIT, &UDRS->flags))
> > -		goto out;
> > +	if (mode & (FMODE_READ|FMODE_WRITE)) {
> > +		UDRS->last_checked = 0;
> > +		clear_bit(FD_OPEN_SHOULD_FAIL_BIT, &UDRS->flags);
> > +		check_disk_change(bdev);
> > +		if (test_bit(FD_DISK_CHANGED_BIT, &UDRS->flags))
> > +			goto out;
> > +		if (test_bit(FD_OPEN_SHOULD_FAIL_BIT, &UDRS->flags))
> > +			goto out;
> > +	}
> > 
> >  	res = -EROFS;
> > 
> > 
> > 
> > 
> 
> I have a problem with this patch. It only fixes one of the regressions
> caused by the original change to the floppy driver. It does not address the
> user land breakage of removing the NODELAY flag checks.

Does the same problem also happen in Linus's tree?  If not, any hints on
the patch that might have fixed it there?

thanks,

greg k-h