linux-kernel - Re: [Regression?] Commit cb4f71c429 deliberately changes order of network interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Aug 2016 16:51:20 -0400
From:   lsorense@...lub.uwaterloo.ca (Lennart Sorensen)
To:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:     Ralph Sennhauser <ralph.sennhauser@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gregory CLEMENT <gregory.clement@...e-electrons.com>
Subject: Re: [Regression?] Commit cb4f71c429 deliberately changes order of
 network interfaces

On Wed, Aug 24, 2016 at 09:52:00PM +0200, Thomas Petazzoni wrote:
> I'll let the platform maintainers decide what's the least
> intrusive/problematic option. Both solutions have drawbacks, so it's
> really a "political" decision to make here.

I think the main valid argument for a revert is that it violates the
documented dtb ordering rule.  It also fails to actually do what it was
intended to do since network device probing order really isn't defined
in linux and if you care you should fix it in userspace.  Fixing a
regression would be a side effect, and since the ordering isn't certain
anyhow, anyone that did see a regression was doing it "wrong" already,
although also anyone that saw a benefit from the change was also doing it
"wrong".

> Not only async probing, but also PCIe devices, as you mentioned
> earlier :-)

Yeah they better come up with a safer way to determine which network
device is which from user space.

-- 
Len Sorensen