linux-kernel - Re: [PATCH net-next] net: dsa: rename switch operations structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4265fdc-1624-7c40-5779-786bdb63375d@gmail.com>
Date:   Wed, 24 Aug 2016 14:15:39 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next] net: dsa: rename switch operations structure

On 08/23/2016 09:38 AM, Vivien Didelot wrote:
> Now that the dsa_switch_driver structure contains only function pointers
> as it is supposed to, rename it to the more appropriate dsa_switch_ops,
> uniformly to any other operations structure in the kernel.
> 
> No functional changes here, basically just the result of something like:
> s/dsa_switch_driver *drv/dsa_switch_ops *ops/g
> 
> However keep the {un,}register_switch_driver functions and their
> dsa_switch_drivers list as is, since they represent the -- likely to be
> deprecated soon -- legacy DSA registration framework.
> 
> In the meantime, also fix the following checks from checkpatch.pl to
> make it happy with this patch:
> 
>     CHECK: Comparison to NULL could be written "!ops"
>     #403: FILE: net/dsa/dsa.c:470:
>     +	if (ops == NULL) {
> 
>     CHECK: Comparison to NULL could be written "ds->ops->get_strings"
>     #773: FILE: net/dsa/slave.c:697:
>     +		if (ds->ops->get_strings != NULL)
> 
>     CHECK: Comparison to NULL could be written "ds->ops->get_ethtool_stats"
>     #824: FILE: net/dsa/slave.c:785:
>     +	if (ds->ops->get_ethtool_stats != NULL)
> 
>     CHECK: Comparison to NULL could be written "ds->ops->get_sset_count"
>     #835: FILE: net/dsa/slave.c:798:
>     +		if (ds->ops->get_sset_count != NULL)
> 
>     total: 0 errors, 0 warnings, 4 checks, 784 lines checked
> 
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!
-- 
Florian