linux-kernel - Re: [Patch v8] driver/clk/clk-si5338: Add common clock framework driver for si5338

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160824044821.GS6502@codeaurora.org>
Date:   Tue, 23 Aug 2016 21:48:21 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     kbuild test robot <lkp@...el.com>
Cc:     York Sun <york.sun@....com>, kbuild-all@...org,
        linux-clk@...r.kernel.org, York Sun <yorksun@...escale.com>,
        Mike Turquette <mturquette@...libre.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Andrey Filippov <andrey@...hel.com>,
        Paul Bolle <pebolle@...cali.nl>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch v8] driver/clk/clk-si5338: Add common clock framework
 driver for si5338

On 08/24, kbuild test robot wrote:
> 
>   2827		if (drv_type < 0)
>   2828			return drv_type;
>   2829	
>   2830		drv_vdd =  get_drv_vdd(drvdata, i);
>   2831		if (drv_vdd < 0)
>   2832			return drv_vdd;
>   2833	
>   2834		drv_trim = get_drv_trim(drvdata, i);
>   2835		if (drv_trim < 0)
>   2836			return drv_trim;
>   2837	
>   2838		drv_invert = get_drv_invert(drvdata, i);
>   2839		if (drv_invert < 0)
>   2840			return drv_invert;
>   2841	
>   2842		for (j = 0; drv_configs[j].description; j++) {
> > 2843			if (drv_configs[j].fmt == drv_type &&
>   2844			    drv_configs[j].vdd == drv_vdd &&
>   2845			    drv_configs[j].trim == drv_trim &&
>   2846			    (drv_invert | (drv_configs[j].invert >> 2)) ==
>   2847				((drv_configs[j].invert & 3) |
>   2848				 (drv_configs[j].invert>>2)))

It might be better to write it as a set of continues instead so
that it isn't one complicated conditional

				config = &drv_configs[j];
				if (config->fmt != drv_type)
					continue;
				if (config->vdd != drv_vdd)
					continue;
				...
				seq_puts()
				match = 1;
				break;
				

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project