linux-kernel - Re: [PATCH 06/10] reset: socfpga: add driver Kconfig option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472109780.3032.20.camel@pengutronix.de>
Date:   Thu, 25 Aug 2016 09:23:00 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Dinh Nguyen <dinguyen@...nsource.altera.com>
Cc:     linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Arnd Bergmann <arnd@...db.de>, Axel Lin <axel.lin@...ics.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Lee Jones <lee.jones@...aro.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 06/10] reset: socfpga: add driver Kconfig option

Am Mittwoch, den 24.08.2016, 10:26 -0500 schrieb Dinh Nguyen:
> Hi Philipp,
> 
> just a minor nit:
> 
> On 08/24/2016 08:28 AM, Philipp Zabel wrote:
> > Visible only if COMPILE_TEST is enabled, this allows to include the
> > driver in build tests.
> > 
> > Cc: Dinh Nguyen <dinguyen@...nsource.altera.com>
> > Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> > ---
> >  drivers/reset/Kconfig  | 6 ++++++
> >  drivers/reset/Makefile | 2 +-
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 6ac631e..354e281 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -49,6 +49,12 @@ config RESET_PISTACHIO
> >  	help
> >  	  This enables the reset driver for ImgTec Pistachio SoCs.
> >  
> > +config RESET_SOCFPGA
> > +	bool "SoC FPGA Reset Driver" if COMPILE_TEST
> 
> Prefer to be "SoCFPGA", no space in between.
>
[...]
> 
> Otherwise,
> 
> Acked-by: Dinh Nguyen <dinguyen@...nsource.altera.com>

Thank you, I'll fix this.

regards
Philipp