linux-kernel - Re: [PATCH 09/10] reset: zynq: add driver Kconfig option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1472109786.3032.21.camel@pengutronix.de>
Date:   Thu, 25 Aug 2016 09:23:06 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, Axel Lin <axel.lin@...ics.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Lee Jones <lee.jones@...aro.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Moritz Fischer <moritz.fischer@...us.com>,
        Michal Simek <michal.simek@...inx.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>
Subject: Re: [PATCH 09/10] reset: zynq: add driver Kconfig option

Am Donnerstag, den 25.08.2016, 10:08 +0900 schrieb Masahiro Yamada:
> 2016-08-25 2:48 GMT+09:00 Masahiro Yamada <yamada.masahiro@...ionext.com>:
> > 2016-08-24 22:29 GMT+09:00 Philipp Zabel <p.zabel@...gutronix.de>:
> >> Visible only if COMPILE_TEST is enabled, this allows to include the
> >> driver in build tests.
> >>
> >> Cc: Moritz Fischer <moritz.fischer@...us.com>
> >> Cc: Michal Simek <michal.simek@...inx.com>
> >> Cc: Sören Brinkmann <soren.brinkmann@...inx.com>
> >> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> >> ---
> >>  drivers/reset/Kconfig  | 6 ++++++
> >>  drivers/reset/Makefile | 2 +-
> >>  2 files changed, 7 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> >> index 17030e2..86b49a2 100644
> >> --- a/drivers/reset/Kconfig
> >> +++ b/drivers/reset/Kconfig
> >> @@ -67,6 +67,12 @@ config RESET_SUNXI
> >>         help
> >>           This enables the reset driver for Allwinner SoCs.
> >>
> >> +config RESET_ZYNQ
> >> +       bool "ZYNQ Reset Driver" if COMPILE_TEST
> >> +       default ARCH_ZYNQ
> >> +       help
> >> +         This enables the reset driver for Xilinx Zynq FPGAs.
> >> +
> >
> > Please move this below RESET_UNIPHIER
> > as I assume you are sorting Kconfig entries alphabetically.

Yes, that was my intention.

> > Otherwise,
> >
> > Reviewed-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> >
> 
> 
> 
> 
> >> +         This enables the reset driver for Xilinx Zynq FPGAs.
> 
> 
> One more thing, I thought this statement is not precise
> because Zynq is not only an FPGA,
> but ARM SoC + FPGA.
> 
> Please consider to reword
> 
> "This enables the reset driver for Xilinx Zynq SoC"

I'll change it to SoCs, thanks.

regards
Philipp