linux-kernel - RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <423FD6710FB8FB4F8728F93591889F9A15FA96FC@avsrvexchmbx1.microsemi.net>
Date:   Wed, 24 Aug 2016 23:01:20 +0000
From:   David Carroll <david.carroll@...rosemi.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "dl-esc-Aacraid Linux Driver" <aacraid@...rosemi.com>,
        "James E. J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Julia Lawall <julia.lawall@...6.fr>
Subject: RE: [PATCH 1/7] aacraid: Use memdup_user() rather than duplicating
 its implementation

> >
> > Hi Markus,
> >
> > Patch 2/7 should precede Patch 1/7, as falling into kfree() would not look
> pretty.
> 
> Do you eventually prefer that this source code adjustment should be combined
> with the update suggestion "[2/7] aacraid: One function call less in
> aac_send_raw_srb() after error detection" in a single update step?
> 

Hi Markus,

My primary objective in this would be the ability to bisect ... The secondary would be one issue/patch. I think my preference would be to swap patches 1 and 2.

Thanks, -Dave